Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update required python version #24

Merged
merged 10 commits into from
Apr 5, 2024
Merged

Update required python version #24

merged 10 commits into from
Apr 5, 2024

Conversation

Thanhphan1147
Copy link
Collaborator

@Thanhphan1147 Thanhphan1147 commented Apr 4, 2024 •
edited
Loading

Checklist

  • The contributing guide was applied
  • The documentation is generated using src-docs
  • The PR is tagged with appropriate label (urgent, trivial, complex)

@Thanhphan1147 Thanhphan1147 requested a review from a team as a code owner April 4, 2024 12:28
mthaddon
mthaddon reviewed Apr 4, 2024
View reviewed changes
Copy link

@mthaddon mthaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think poetry.lock will need updating won't it? I see a reference to python < 3.12 in there.

@Thanhphan1147 Thanhphan1147 marked this pull request as draft April 4, 2024 12:30
@Thanhphan1147
Copy link
Collaborator Author

I think poetry.lock will need updating won't it? I see a reference to python < 3.12 in there.

Yes, I'll update the dependencies in pyproject.toml and rerun poetry.

@Thanhphan1147 Thanhphan1147 marked this pull request as ready for review April 4, 2024 16:09
arturo-seijas
arturo-seijas previously approved these changes Apr 5, 2024
View reviewed changes
arturo-seijas
arturo-seijas previously approved these changes Apr 5, 2024
View reviewed changes
weiiwang01
weiiwang01 approved these changes Apr 5, 2024
View reviewed changes
.github/test-pre-script.sh Show resolved Hide resolved
@Thanhphan1147 Thanhphan1147 requested review from mthaddon, arturo-seijas and a team April 5, 2024 16:21
@Thanhphan1147 Thanhphan1147 merged commit 137b755 into main Apr 5, 2024
19 checks passed
@Thanhphan1147 Thanhphan1147 deleted the update_python_version branch April 5, 2024 16:41
cbartz
cbartz reviewed Apr 5, 2024
View reviewed changes
.github/workflows/integration_test.yaml
@@ -10,5 +10,5 @@ jobs:
with:
pre-run-script: .github/test-pre-script.sh
self-hosted-runner: true
self-hosted-runner-label: "edge"
self-hosted-runner-label: "jammy"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Thanhphan1147 is this really intended? the "jammy" label is automatically added by operator workflows since canonical/operator-workflows#275 . As no flavour is specified, you may still get "edge" as one is randomly selected.
Same for .github/workflows/test.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiiwang01 weiiwang01 weiiwang01 approved these changes

@cbartz cbartz cbartz left review comments

@varshigupta12 varshigupta12 varshigupta12 approved these changes

@mthaddon mthaddon Awaiting requested review from mthaddon

@arturo-seijas arturo-seijas Awaiting requested review from arturo-seijas

Assignees
No one assigned
Labels
trivial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Thanhphan1147 @varshigupta12 @mthaddon @cbartz @weiiwang01 @arturo-seijas